[PATCH] D95667: [NFC][RISCV] Remove redundant pseudo instructions for vector load/store.

[Hsiangkai Wang via Phabricator via llvm-commits]

HsiangKai added inline comments.
Herald added a subscriber: vkmr.


================
Comment at: llvm/lib/Target/RISCV/RISCVInstrInfoVPseudos.td:3165
 // Pseudos Unit-Stride Loads and Stores
-foreach eew = EEWList in {
-  defm PseudoVLE # eew : VPseudoUSLoad;
-  defm PseudoVSE # eew : VPseudoUSStore;
-}
+defm PseudoVL : VPseudoUSLoad</*fault-only-first*/false>;
+defm PseudoVS : VPseudoUSStore;
----------------
jrtc27 wrote:
> khchen wrote:
> > `/*fault-only-first=*/` is correct style.
> No, `/*isFF=*/`, it's always the name of the argument (and `fault-only-first` isn't even a valid identifier).
Yeah, I didn't intend to use the argument name in the comment. I use the name in the V specification for its purpose in the comments. Anyway, I will change it to `/*isFF=*/`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95667/new/

https://reviews.llvm.org/D95667