[PATCH] D95631: [TailDuplicator] Add TargetInstrInfo hook to modify the TailDuplicateSize default threshold
Sjoerd Meijer via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Jan 29 03:29:18 PST 2021
SjoerdMeijer added subscribers: fhahn, samparker, t.p.northover.
SjoerdMeijer added a comment.
I don't think I would mind merging this with D95632 <https://reviews.llvm.org/D95632> to keep things in one place; don't think separating brings much value in this case.
Also adding some more folks who might care about AArch64 tuning: @fhahn, @samparker , @t.p.northover
We have seen a case for which generating straight-line code for tail blocks is really good for performance. From memory, this was a relatively small function that was called a lot of times, so that this makes a big difference.
But since this is changing a generic AArch64 codegen option/value, I think @NickGuy you need to show that this is good/bad/neutral for some more code other than our one motivation example.
I think a target hook for TailDuplicateSize makes sense though, it is easy to imagine I think that different targets would have different preferences for this.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D95631/new/
https://reviews.llvm.org/D95631
More information about the llvm-commits
mailing list