[PATCH] D95432: AMDGPU/GlobalISel: Combine uniform icmp with select

Jay Foad via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 29 03:02:04 PST 2021


foad added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUCombine.td:40
 
+def uniform_icmp_select_matchdata : GIDefMatchData<"AMDGPURegBankCombinerHelper::UniformICmpSelectMatchInfo">;
+
----------------
You don't need AMDGPURegBankCombinerHelper::UniformICmpSelectMatchInfo at all. You can just use Register. See D95645 for an example.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95432/new/

https://reviews.llvm.org/D95432



More information about the llvm-commits mailing list