[PATCH] D95158: Use DataExtractor to decode SLEB128 in android_relas.

Fri Jan 29 00:54:17 PST 2021

rahmanl added a comment.

In D95158#2530158 <https://reviews.llvm.org/D95158#2530158>, @grimar wrote:

> In D95158#2530153 <https://reviews.llvm.org/D95158#2530153>, @jhenderson wrote:
>
>> In D95158#2530091 <https://reviews.llvm.org/D95158#2530091>, @grimar wrote:
>>
>>> In D95158#2529509 <https://reviews.llvm.org/D95158#2529509>, @rahmanl wrote:
>>>
>>>> I am surprised this patch hasn't been automatically updated to show the committed status after I pushed it (https://github.com/llvm/llvm-project/commit/3ca502a7d60787abe14db1fa541950ff79c7585b). Maybe I should've used `arc land` instead of `git push`?
>>>
>>> Probably because you've used "Differential **R**evision". The latter word should be "**r**evision"
>>
>> No, it definitely should be `Revision` (upper-case).
>
> Seems there is no difference what to use then. I believe I always used lower-case. E.g rG029644ee510792120f1c0daf32989b401d4ce871 <https://reviews.llvm.org/rG029644ee510792120f1c0daf32989b401d4ce871>.

Thanks @grimar and @jhenderson.
I think the 'differential revision' line was added automatically when I pushed.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95158/new/

https://reviews.llvm.org/D95158