[PATCH] D95158: Use DataExtractor to decode SLEB128 in android_relas.

Fri Jan 29 00:44:17 PST 2021

jhenderson added a subscriber: mehdi_amini.
jhenderson added a comment.

In D95158#2530091 <https://reviews.llvm.org/D95158#2530091>, @grimar wrote:

> In D95158#2529509 <https://reviews.llvm.org/D95158#2529509>, @rahmanl wrote:
>
>> I am surprised this patch hasn't been automatically updated to show the committed status after I pushed it (https://github.com/llvm/llvm-project/commit/3ca502a7d60787abe14db1fa541950ff79c7585b). Maybe I should've used `arc land` instead of `git push`?
>
> Probably because you've used "Differential **R**evision". The latter word should be "**r**evision"

No, it definitely should be `Revision` (upper-case). I always use git push, and my last commit worked fine - see rGb37a349ff2442e73ceafeee982afb430359e08b1 <https://reviews.llvm.org/rGb37a349ff2442e73ceafeee982afb430359e08b1>. Your format looks the same as mine, so either Phabricator had a fit and just failed to link the two up this time, or something else is the matter. @mehdi_amini, any ideas?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95158/new/

https://reviews.llvm.org/D95158