[PATCH] D90948: [WebAssembly] call_indirect issues table number relocs

Andy Wingo via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 29 00:01:04 PST 2021


wingo added a comment.

In D90948#2528890 <https://reviews.llvm.org/D90948#2528890>, @tlively wrote:

> I'm also not 100% sure of how things work today, but I hope it wouldn't be too difficult to emit the MVP table precisely when necessary by seeing whether or not it would be empty immediately before writing out the final binary. I'm perfectly willing to believe that I'm missing something that prevents that from working, though.

Unfortunately this is not the case.  You can still have

  void call(void (*f)(void)) {
    f();
  }

in the compilation unit, causing `call_indirect` to be emitted but no function pointer definition.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90948/new/

https://reviews.llvm.org/D90948



More information about the llvm-commits mailing list