[PATCH] D95591: [yaml2obj/obj2yaml] - Implement program header table as a special Chunk.

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 28 23:56:34 PST 2021


grimar marked an inline comment as done.
grimar added a comment.

In D95591#2529833 <https://reviews.llvm.org/D95591#2529833>, @MaskRay wrote:

> Program headers are not subsidiary of the section header table. `ProgramHeaderType` is fine, but it probably should not have `Segments:`. The program headers can still be described the current `ProgramHeaders:`.

This was already discussed.
We can rename the "Sections:" to "Layout:". Or allow both. See https://reviews.llvm.org/D93678#2492777.
Having `Segments:` in `ProgramHeader` Type is consistent with `SectionHeaderTable` type.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95591/new/

https://reviews.llvm.org/D95591



More information about the llvm-commits mailing list