[PATCH] D94938: [lld-macho][NFC] Add some new version options, plus a new option group for versions

[Jez Ng via Phabricator via llvm-commits]

int3 accepted this revision.
int3 added inline comments.


================
Comment at: lld/MachO/Options.td:235
+
+def grp_version : OptionGroup<"version">, HelpText<"VERSION CONTROL">;
+
----------------
"version control" makes me think of, well, git and hg... how about "target version"?


================
Comment at: lld/MachO/Options.td:273
+     MetaVarName<"<version>">,
+     HelpText<"Oldest MacCatalyst version for which linked output is useable">,
      Flags<[HelpHidden]>,
----------------
nit: [[ https://books.google.com/ngrams/graph?content=usable%2Cuseable&year_start=1800&year_end=2019&corpus=26&smoothing=3&direct_url=t1%3B%2Cusable%3B%2Cc0%3B.t1%3B%2Cuseable%3B%2Cc0 | usable is the more common spelling ]]


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94938/new/

https://reviews.llvm.org/D94938