[PATCH] D95593: Detect Source Drift with Propeller's basic-block-sections=list=

[Snehasish Kumar via Phabricator via llvm-commits]

snehasish accepted this revision.
snehasish added a comment.
This revision is now accepted and ready to land.

lgtm



================
Comment at: llvm/test/CodeGen/X86/bb_sections_hash_mismatch.ll:18-19
+
+; SOURCE_DRIFT-NOT: .section .text
+; NO_SOURCE_DRIFT: .section .text
----------------
tmsriram wrote:
> snehasish wrote:
> > This was quite confusing at first glance.
> > SOURCE-DRIFT-NOT is checking for the absence of .section .text (when the check is enabled)
> > NO_SOURCE_DRIFT is checking for the absence option being enabled.
> > 
> > Perhaps the second one is clearer if named `HASH-CHECK-DISABLED`?
> > Also is it worthwhile to add a test case for the no annotation case (common case) to catch future regression?
> > 
> There are already test cases with .ll files and without the metadata that check for bb sections. Is that alright?
Yes, sgtm.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95593/new/

https://reviews.llvm.org/D95593