[PATCH] D95652: [GlobalISel] Remove hint instructions in generic InstructionSelect code.

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 28 18:48:13 PST 2021


arsenm added inline comments.


================
Comment at: llvm/lib/CodeGen/GlobalISel/InstructionSelect.cpp:138-139
+      if (isPreISelGenericOptimizationHint(MI.getOpcode())) {
+        assert(MI.getOpcode() == TargetOpcode::G_ASSERT_ZEXT &&
+               "G_ASSERT_ZEXT is the only hint right now!");
+        LLVM_DEBUG(dbgs() << "Is hint; removing.\n");
----------------
This assert seems pointless


================
Comment at: llvm/lib/CodeGen/GlobalISel/InstructionSelect.cpp:140
+               "G_ASSERT_ZEXT is the only hint right now!");
+        LLVM_DEBUG(dbgs() << "Is hint; removing.\n");
+        Register DstReg = MI.getOperand(0).getReg();
----------------
I think this is just noise printing


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95652/new/

https://reviews.llvm.org/D95652



More information about the llvm-commits mailing list