[PATCH] D95649: [GlobalISel] Implement regbankselect for G_ASSERT_ZEXT

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 28 18:45:35 PST 2021


arsenm added inline comments.


================
Comment at: llvm/lib/CodeGen/GlobalISel/RegBankSelect.cpp:630-631
+    const RegisterBank *RB = MRI->getRegBankOrNull(MI.getOperand(1).getReg());
+    // We can assume every instruction above this one has a selected register
+    // bank.
+    assert(RB && "Expected source register to have a register bank?");
----------------
I'm not sure this is actually true, it just happens to be true with the basic implementation now


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95649/new/

https://reviews.llvm.org/D95649



More information about the llvm-commits mailing list