[PATCH] D94050: [WebAssembly] Handle EH terminate pads for cleanup

[Thomas Lively via Phabricator via llvm-commits]

tlively accepted this revision.
tlively added a comment.
This revision is now accepted and ready to land.

LGTM besides that one comment!



================
Comment at: llvm/lib/Target/WebAssembly/WebAssemblyHandleEHTerminatePads.cpp:125
+    // a single BB.
+    MachineBasicBlock *CatchBB = Call->getParent();
+    assert(CatchBB->isEHPad());
----------------
Is it possible for one BB to contain multiple calls to `__clang_call_terminate`? If so, that BB would end up with multiple `catch_all`s in the current code. Would it be worth asserting that this doesn't happen?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94050/new/

https://reviews.llvm.org/D94050