[PATCH] D95309: [TableGen] Fix anonymous record self-reference in foreach and multiclass

David Blaikie via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 28 12:15:19 PST 2021


dblaikie added a comment.

In D95309#2528208 <https://reviews.llvm.org/D95309#2528208>, @Paul-C-Anagnostopoulos wrote:

> Ah, then I don't think that build matters.
>
> Perhaps David will commit it for you. Otherwise I will learn how to do it.

Generally if you have commit access and have approved a patch & the patch author mentions they don't have commit access - you can go ahead and commit it for them.

Basically `arc patch DXXXX` will pull their patch down, and then you can `git commit --amend --author=...` to set the author information to the original author (I usually end up having to search for the user on the LLVM mailing list to find their real name and email address (so the author can be "Firstname Lastname <user at domain.com>") rather than their phabricator username if possible) and commit/push that like any other patch. I think some of the details are here: https://llvm.org/docs/DeveloperPolicy.html#commit-messages


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95309/new/

https://reviews.llvm.org/D95309



More information about the llvm-commits mailing list