[PATCH] D95139: [SVE][LoopVectorize] Add support for extracting the last lane of a scalable vector

Thu Jan 28 08:14:53 PST 2021

fhahn added inline comments.

================
Comment at: llvm/test/Transforms/LoopVectorize/AArch64/neon-extract-last-veclane.ll:3
+
+target datalayout = "e-m:e-i8:8:32-i16:16:32-i64:64-i128:128-n32:64-S128"
+target triple = "aarch64-unknown-linux-gnu"
----------------
david-arm wrote:
> fhahn wrote:
> > This test does not need to be neon specific, right? extracting the last lane for fixed vectors should be tested fairly well already, so not sure if the test is needed at all?
> Similar to what I mentioned in the commit message, I deliberately added a llvm_unreachable() in the code that I've changed and I found no explicit tests for this at all. There is some limited coverage, but accidentally so in cases where the test was actually trying to test something else. How about I move this to a generic place?
Sounds good to me

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95139/new/

https://reviews.llvm.org/D95139