[PATCH] D95489: [AMDGPU] Do not reassign spilled registers

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/GCNNSAReassign.cpp:194
+      // InlineSpiller does not call LRM::assign() after an LI split leaving
+      // it in an incosistent state, so we cannot call LRM::unassign().
+      // Skip reassign if a register has originated from such split.
----------------
Typo incosistent


================
Comment at: llvm/lib/Target/AMDGPU/GCNRegBankReassign.cpp:474
 
+  // InlineSpiller does not call LRM::assign() after an LI split leaving it
+  // in an incosistent state, so we cannot call LRM::unassign(). Skip reassign
----------------
I don't understand if this is a bug with LRM::assign or not


================
Comment at: llvm/lib/Target/AMDGPU/GCNRegBankReassign.cpp:475
+  // InlineSpiller does not call LRM::assign() after an LI split leaving it
+  // in an incosistent state, so we cannot call LRM::unassign(). Skip reassign
+  // if a register has originated from such split.
----------------
Typo incosistent


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95489/new/

https://reviews.llvm.org/D95489