[PATCH] D95603: [CostModel]Add cost model for experimental.vector.reverse

[David Sherwood via Phabricator via llvm-commits]

david-arm added inline comments.


================
Comment at: llvm/lib/Target/AArch64/AArch64TargetTransformInfo.cpp:1244
+      { TTI::SK_Reverse, MVT::nxv2i64, 1 },
+      { TTI::SK_Reverse, MVT::nxv8f16, 1 },
+      { TTI::SK_Reverse, MVT::nxv4f32, 1 },
----------------
I think we need an entry for MVT::nxv8bf16 here too.


================
Comment at: llvm/test/Analysis/CostModel/AArch64/getIntrinsicInstrCost-vector-reverse.ll:10
+
+define void @vector_reverse_v16i8(<16 x i8> %a) {
+; CHECK-LABEL: 'vector_reverse_v16i8':
----------------
Same suggestion as I left in D95598 about reducing number of functions and CHECK lines, but feel free to ignore it if you prefer the tests this way!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95603/new/

https://reviews.llvm.org/D95603