[PATCH] D94525: [SVE][CodeGen] Remove performMaskedGatherScatterCombine

[Kerry McLaughlin via Phabricator via llvm-commits]

kmclaughlin added inline comments.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp:4347
+    EVT NewIdxVT = IdxVT.changeVectorElementType(EltTy);
+    Index = DAG.getNode(ISD::SIGN_EXTEND, sdl, NewIdxVT, Index);
+  }
----------------
david-arm wrote:
> Do we want to switch between zero, sign or any extend depending upon what the target wants? I noticed in the original perform...Combine code we chose SIGN or ZERO extend based on the isIndexSigned() result - not sure if we still need something similar here or not.
Hi @david-arm, I chose sign extension here because the index type at this point is set to the default of `SIGNED_UNSCALED`. Though if the index here is a zext node, getNode() will return an `ISD::ZERO_EXTEND` instead, so I think the correct extension will still be applied.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94525/new/

https://reviews.llvm.org/D94525