[PATCH] D95605: [llvm-readobj/elf] - Report "bitcode files are not supported" warning for bitcode files.

Thu Jan 28 05:37:40 PST 2021

jhenderson added inline comments.

================
Comment at: llvm/test/tools/llvm-readobj/basic.test:33-34
+RUN:   FileCheck --check-prefix=BITCODE -DFILE1=%t.bc.1 -DFILE2=%t.bc.2 %s
+RUN: llvm-readobj %t.bc.1 %t.bc.2 2>&1 | \
+RUN:   FileCheck --check-prefix=BITCODE -DFILE1=%t.bc.1 -DFILE2=%t.bc.2 %s
+
----------------
grimar wrote:
> jhenderson wrote:
> > Did you mean to repeat this check twice? Doesn't seem to be much point in that... I'm guessing you meant to do them the other way around.
> It is correct: the first tests the `llvm-readelf`, and the second calls `llvm-readobj`.
Oops, thanks!

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95605/new/

https://reviews.llvm.org/D95605