[PATCH] D95591: [yaml2obj/obj2yaml] - Implement program header table as a special Chunk.

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 28 05:27:04 PST 2021


jhenderson accepted this revision.
jhenderson added a comment.
This revision is now accepted and ready to land.

LGTM, with one nit.



================
Comment at: llvm/test/tools/yaml2obj/ELF/program-header.yaml:357-358
+
+## Check the size of the file: start of program headers (280) +
+## size of program headers(56) * number of program headers(1) == 392.
+
----------------
Copy paste error? The file size is 336 in this case.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95591/new/

https://reviews.llvm.org/D95591



More information about the llvm-commits mailing list