[PATCH] D92873: [cmake] Make ExecutionEngine/Orc/Shared depend on intrinsics_gen to fix modules build

Stefan Gränitz via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 28 04:03:26 PST 2021


sgraenitz added a comment.

Sorry, I didn't see this over the holidays. Yesterday, I fell over it eventually, got confused and checked the change :-) This was certainly the right thing to do for unblocking the bots. I am not sure, however, if we want to keep it like that in the long-term. OrcShared should only have things that are required by both, OrcJIT and OrcTargetProcess. The former already depends on intrinsics_gen and the latter doesn't need it.

So, what would it take to get rid of it again? I guess the underlying issue is that TargetProcessControlTypes somehow pulls in ExecutionEngine. That shouldn't be necessary. I can reproduce the issue and I will see how to avoid it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92873/new/

https://reviews.llvm.org/D92873



More information about the llvm-commits mailing list