[PATCH] D95591: [yaml2obj/obj2yaml] - Implement program header table as a special Chunk.

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 28 03:17:45 PST 2021


grimar added a comment.

In D95591#2527530 <https://reviews.llvm.org/D95591#2527530>, @jhenderson wrote:

> I might well have missed it, but I don't recall seeing any dedicated obj2yaml tests?

There is a `obj2yaml/ELF/program-headers.yaml` test which checks how the
program header table is emitted. But there is no much else we have to test currently I think,
because at this moment `obj2yaml` just emits the description in the begining of sections list.
It can't dump the table on a proper position or dump the "Offset" key.
I.e. this is already covered by the test. I am going to improve it slightly though (e.g. will add a comment).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95591/new/

https://reviews.llvm.org/D95591



More information about the llvm-commits mailing list