[PATCH] D95598: [AArch64][SVE]Add cost model for broadcast shuffle

[Sander de Smalen via Phabricator via llvm-commits]

sdesmalen added inline comments.


================
Comment at: llvm/lib/Target/AArch64/AArch64TargetTransformInfo.cpp:1194
                                    int Index, VectorType *SubTp) {
-  if (Kind == TTI::SK_Broadcast || Kind == TTI::SK_Transpose ||
-      Kind == TTI::SK_Select || Kind == TTI::SK_PermuteSingleSrc) {
----------------
Why did you remove this condition?


================
Comment at: llvm/lib/Target/AArch64/AArch64TargetTransformInfo.cpp:1236
+
+    static const CostTblEntry ScalableShuffleTbl[] = {
+        {TTI::SK_Broadcast, MVT::nxv16i8, 1},
----------------
Can't these be moved into the table above? (`ShuffleTbl`)


================
Comment at: llvm/test/Analysis/CostModel/AArch64/sve-shuffle-broadcast.ll:101
+
+define <vscale x 4 x float> @slapt_v4f32(<vscale x 4 x float> %v){
+; CHECK-LABEL: 'slapt_v4f32':
----------------
s/slapt/broadcast/ (same for tests below)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95598/new/

https://reviews.llvm.org/D95598