[PATCH] D94072: [MC][ELF] Fix accepting abbreviated form with sh_flags and sh_entsize

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 28 00:02:57 PST 2021


jhenderson accepted this revision.
jhenderson added a comment.
This revision is now accepted and ready to land.

LGTM, with nit.



================
Comment at: llvm/test/MC/ELF/section-omitted-attributes.s:14
+
+# Likewise, except that the '.rodata' prefix implies SHF_ALLOC
+.section .rodata.cst8,"aM", at progbits,8
----------------
Nit: add full stop at end of comment.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94072/new/

https://reviews.llvm.org/D94072



More information about the llvm-commits mailing list