[PATCH] D95500: [AMDGPU] Fix WMM Entry SCC preservation

Carl Ritson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 27 20:29:43 PST 2021


critson marked 4 inline comments as done.
critson added inline comments.


================
Comment at: llvm/test/CodeGen/AMDGPU/wqm.mir:63
+name:            test_wwm_scc2
+alignment:       1
+exposesReturnsTwice: false
----------------
foad wrote:
> Remove most of this? Usually you only need `name`, `tracksRegLiveness` and `body`. 
`registers` are needed if types are not embedded.
I have switch the new test to embedded types.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95500/new/

https://reviews.llvm.org/D95500



More information about the llvm-commits mailing list