[PATCH] D95424: [CodeGenPrepare] Also skip lifetime.end intrinsic when check return block in dupRetToEnableTailCallOpts

JunMa via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 27 20:08:19 PST 2021


junparser added a comment.

In D95424#2527105 <https://reviews.llvm.org/D95424#2527105>, @aqjune wrote:

> Hi,
> This transformation is basically removing lifetime.end, is my understanding right?

Yes, It remove lifetime.end in the new duplicated return block.

> In terms of correctness, this is fine IMO because removing lifetime.end makes the program more defined.
> It is also syntactically fine to have an unmatched lifetime.start because LLVM already removes unreachable code that may contain lifetime.end.

Yes, you are right, also IMO lifetime.end does not have any effect  in return block.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95424/new/

https://reviews.llvm.org/D95424



More information about the llvm-commits mailing list