[PATCH] D95547: [CSSPGO] Support of CS profiles in extended binary format.

Hongtao Yu via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 27 16:50:42 PST 2021


hoy added inline comments.


================
Comment at: llvm/include/llvm/ProfileData/SampleProf.h:442
   bool isBaseContext() const { return CallingContext.empty(); }
   StringRef getName() const { return Name; }
   StringRef getCallingContext() const { return CallingContext; }
----------------
wmi wrote:
> hoy wrote:
> > wmi wrote:
> > > Nit: I feel getNameWithoutContext is more straightforward.
> > you mean for the `getName` function?
> Yes.
Sounds good.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95547/new/

https://reviews.llvm.org/D95547



More information about the llvm-commits mailing list