[PATCH] D95566: [GlobalISel] Implement computeKnownBits for G_ASSERT_ZEXT

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/lib/CodeGen/GlobalISel/GISelKnownBits.cpp:416
+      SrcBitWidth = MI.getOperand(2).getImm();
+    else
+      SrcBitWidth = SrcTy.isPointer()
----------------
This should get braces


================
Comment at: llvm/unittests/CodeGen/GlobalISel/KnownBitsTest.cpp:924
+
+   %assert16:_(s64) = G_ASSERT_ZEXT %copy, 16
+   %copy_assert16:_(s64) = COPY %assert16
----------------
I think testing the boundary conditions 1, 63 are more useful than a bunch of powers of 2


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95566/new/

https://reviews.llvm.org/D95566