[PATCH] D95569: [llvm-objcopy] -O binary: consider SHT_NOBITS sections to be empty

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added a comment.

I did not add `Sec.Type != SHT_NOBITS && ` in D79229 <https://reviews.llvm.org/D79229> because I did not find a use case for this rule... If yours is a real usage, I think it is fine.



================
Comment at: llvm/test/tools/llvm-objcopy/ELF/binary-paddr.test:214
+    Flags:        [ SHF_ALLOC, SHF_EXECINSTR ]
+    Address:      0x10000000
+    AddressAlign: 0x1000
----------------
I'll use a smaller address. If something goes off, this would not create a 260MB output.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95569/new/

https://reviews.llvm.org/D95569