[PATCH] D95547: [CSSPGO] Support of CS profiles in extended binary format.

[Wenlei He via Phabricator via llvm-commits]

wenlei added inline comments.


================
Comment at: llvm/include/llvm/ProfileData/SampleProf.h:454
     assert(!ContextStr.empty());
+    FullContextWithBracket = ContextStr;
     // Note that `[]` wrapped input indicates a full context string, otherwise
----------------
hoy wrote:
> wlei wrote:
> > Should we merge it to the condition in line 462. because as its name "WithBracket", it should always have bracket or we can add a check for the `HasContext`.
> > ```
> > if (HasContext) {
> >   FullContextWithBracket = ContextStr;
> > }
> > ```
> Good point. It really refers to the original input context so that we can use it unconditionally for non-CS profile as well. @wenlei thinking about renaming it OrigContext, what do you think?
Good catch, in this case OrigContext or InputContext makes more sense.. Sorry for the confusion. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95547/new/

https://reviews.llvm.org/D95547