[PATCH] D95399: [flang][fir] Upstream FIR dialect changes.

[Mehdi AMINI via Phabricator via llvm-commits]

mehdi_amini added inline comments.


================
Comment at: flang/lib/Optimizer/Dialect/FIROps.cpp:467
     if (fir::GlobalOp::verifyValidLinkage(linkage))
-      return failure();
+      return mlir::failure();
     mlir::StringAttr linkAttr = builder.getStringAttr(linkage);
----------------
schweitz wrote:
> mehdi_amini wrote:
> > It isn't clear why this is needed?
> Not sure what "this" refers to, but I assume you mean the check/test. This is older code--it may have been here since before MLIR was merged into the mono repo--that predates some of the improvements made to the autogenerated verification code in the last year or so. It may not longer be needed.
I meant that the only diff here (and on other lines in this patch) is adding `mlir::` namespace prefix, however many other mlir Types aren't prefixed, so this seems unnecessary here unless there is some sort of ambiguity?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95399/new/

https://reviews.llvm.org/D95399