[PATCH] D95547: [CSSPGO] Support of CS profiles in extended binary format.
Wenlei He via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Jan 27 12:50:32 PST 2021
wenlei accepted this revision.
wenlei added a comment.
This revision is now accepted and ready to land.
lgtm, with one nit.
================
Comment at: llvm/include/llvm/ProfileData/SampleProf.h:445
StringRef getNameWithContext() const { return FullContext; }
+ StringRef getInputNameWithContext() const { return InputContext; }
----------------
hoy wrote:
> wenlei wrote:
> > What about using `getNameWithContext(bool WithBracket = false)`, also change `InputContext` to `FullContextWithBracket`.
> That looks better. Thanks.
missed the rename of InputContext to FullContextWithBracket?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D95547/new/
https://reviews.llvm.org/D95547
More information about the llvm-commits
mailing list