[PATCH] D95544: [LoopPeel] Use llvm.experimental.noalias.scope.decl for duplicating noalias metadata as needed.

[Nikita Popov via Phabricator via llvm-commits]

nikic added inline comments.


================
Comment at: llvm/lib/Transforms/Utils/LoopPeel.cpp:525
+  SmallVector<MDNode *, 6> LoopLocalNoAliasDeclScopes;
+  identifyNoAliasScopesToClone(L->getBlocks(), LoopLocalNoAliasDeclScopes);
+
----------------
Might make sense to do this once and pass into cloneLoopBlocks?


================
Comment at: llvm/test/Transforms/LoopUnroll/peel-loop-noalias-scope-decl.ll:2
+; NOTE: Assertions have been autogenerated by utils/update_test_checks.py
+; RUN: opt --verify --loop-unroll  -unroll-force-peel-count=1 --verify -S < %s | FileCheck %s
+
----------------
I don't think these `--verify` are needed. opt verifies before and after by default.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95544/new/

https://reviews.llvm.org/D95544