[PATCH] D95539: [LV] Add analysis remark for mixed precision conversions

[Johannes Doerfert via Phabricator via llvm-commits]

jdoerfert added a comment.

In D95539#2525648 <https://reviews.llvm.org/D95539#2525648>, @lebedev.ri wrote:

> This is already caught by `-Wimplicit-float-conversion`/`-Wdouble-promotion` though
> https://godbolt.org/z/o5Pzh4

Yes, but ;)

If you don't vectorize it is half as bad, arguably. Signal to noise might make the FE warnings unusable, every conversion is flagged after all https://godbolt.org/z/6hEjfx



================
Comment at: llvm/lib/Transforms/Vectorize/LoopVectorize.cpp:9292
+        DenseMap<Instruction *, bool> Visited;
+        SmallVector<Instruction *, 8> Worklist;
+        Worklist.push_back(S);
----------------
fhahn wrote:
> Can we collect all FP stores in a first pass, and then do the wordlist traversal for the all fp stores together afterwards? This way, we won't get duplicated remarks, if the same value is stored multiple times.
I was expecting to have a set with all FPExt that have been diagnoses, but either way not duplicating for an FPExt seems reasonable. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95539/new/

https://reviews.llvm.org/D95539