[PATCH] D94465: [RISCV] Frame handling for RISC-V V extension. (2nd. version)

[Craig Topper via Phabricator via llvm-commits]

craig.topper added inline comments.


================
Comment at: llvm/lib/Target/RISCV/RISCVRegisterInfo.cpp:204
+        BuildMI(MBB, II, DL, TII->get(RISCV::ADDI), ScratchReg)
+          .addReg(FrameReg)
+          .addImm(Offset.getFixed());
----------------
I think this also need getKillRegState(FrameRegIsKill)


================
Comment at: llvm/lib/Target/RISCV/RISCVRegisterInfo.cpp:226
+    BuildMI(MBB, II, DL, TII->get(Opc), VL)
+        .addReg(FrameReg, FrameRegIsKill ? RegState::Kill : 0)
+        .addReg(FactorRegister, RegState::Kill);
----------------
Use getKillRegState(FrameRegIsKill)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94465/new/

https://reviews.llvm.org/D94465