[PATCH] D95539: [LV] Add analysis remark for mixed precision conversions

[Roman Lebedev via Phabricator via llvm-commits]

lebedev.ri added a comment.

This is already caught by `-Wimplicit-float-conversion`/`-Wdouble-promotion` though
https://godbolt.org/z/o5Pzh4



================
Comment at: llvm/lib/Transforms/Vectorize/LoopVectorize.cpp:9287
+      if (auto *S = dyn_cast<StoreInst>(&Inst)) {
+        if (!S->getPointerOperandType()->getPointerElementType()->isFloatTy())
+          continue;
----------------
You should be checking the type of the value being stored, not the pointer's element type


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95539/new/

https://reviews.llvm.org/D95539