[PATCH] D91737: [Dexter] Avoid potentially infinite loop in dbgeng driver

Jeremy Morse via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 27 09:29:40 PST 2021


jmorse added a comment.

(/me finally works his way through his backlog...)

Tom wrote:

> The launch method is still called once at the start of a 'debug' session

Cool, I guess "go" more or less matches gdb's "continue" then,

> It could be that the infinite looping/strange behaviour we're seeing is a result of being 'stuck' in library files and dexter repeatedly calling the empty 'go' method of dbgeng?

I think that's it, hence getting it to at least step to make progress in this patch. Dexter is still vulnerable to stepping through all of printf, but at least it'll make progress and not hang forever this way.

(It's been a while since I did battle with COM, fixing dbgengs free-running is making its way slowly up my todo list).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91737/new/

https://reviews.llvm.org/D91737



More information about the llvm-commits mailing list