[PATCH] D94992: [SLP]Merge reorder and reuse shuffles.

[Eric Christopher via Phabricator via llvm-commits]

echristo added inline comments.


================
Comment at: llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp:3503
     case Instruction::ExtractElement: {
+      InstructionCost DeadCost = 0;
       if (NeedToShuffleReuses) {
----------------
Let's describe dead cost here.


================
Comment at: llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp:4339
 
+namespace {
+/// Merges shuffle masks and emits final shuffle instruction, if required.
----------------
I seem to recall we have other classes that do this as well?


================
Comment at: llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp:4392
+    assert((IsFinalized || Mask.empty()) &&
+           "Must be finalized construction of the shuffles.");
+  }
----------------
"Shuffle construction must be finalized"


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94992/new/

https://reviews.llvm.org/D94992