[PATCH] D83890: [DebugInfo] Process DBG_VALUE_LIST in LiveDebugValues

[Vedant Kumar via Phabricator via llvm-commits]

vsk added a comment.

In D83890#2515600 <https://reviews.llvm.org/D83890#2515600>, @jmorse wrote:

> Paging @vsk -- it was a while ago, but do you still have the bitcode from D7406 <https://reviews.llvm.org/D7406> handy, and would you have spare cycles to test it against this (combined patch in D94631 <https://reviews.llvm.org/D94631>)?
>
> Taking a high level view: because variadic variable locations can be part of more than one machine location, here @StephenTozer is adding a VarLoc to each machine location the variable location uses, **and** keeping an index of all VarLocs in LocIndex=0, so that a "cannonical" VarLoc can be looked up.
>
> I'm not concerned about the average performance, as the cost of extra VarLocs will be proportionate to the number of variadic variable locations, which will be small (at least initially). However, keeping everything in a single index risks defeating the CoalescingBitVector improvements by fragmenting the collection of set bits more than it was before, increasing pointer chasing. Hence it'd be good to test against the original motivating example, if possible.

I do still have the bitcode handy, but wasn't able to apply D94631 <https://reviews.llvm.org/D94631> cleanly to my checkout. Happy to report results back, just let me know which hash of llvm-project to apply D94631 <https://reviews.llvm.org/D94631> onto.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83890/new/

https://reviews.llvm.org/D83890