[PATCH] D95217: [LoopVectorize] Fix VPRecipeBuilder::createEdgeMask to correctly generate the mask

[Bjorn Pettersson via Phabricator via llvm-commits]

bjope added inline comments.


================
Comment at: llvm/test/Transforms/LoopVectorize/pr48832.ll:7
+; Since the program has well defined behavior, it should not introduce store poison
+; CHECK-NOT: store <4 x i32> poison,
+
----------------
Maybe safer to use a regexp instead of `<4 x i32>` or explicitly check that we get `store <4 x i32> zeroinitializer`. Or you need to force the vector factor.
Otherwise the test case is fragile to changes in cost model etc (it would for example pass for a different vector factor and then it wouldn't be useful as a regression test any longer).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95217/new/

https://reviews.llvm.org/D95217