[PATCH] D82545: [Debugify] Make the debugify aware of the original (-g) Debug Info

[Adrian Prantl via Phabricator via llvm-commits]

aprantl added inline comments.


================
Comment at: llvm/test/DebugInfo/debugify-each-original-dbginfo.ll:3
+
+; RUN: opt -O2 -verify-each-debuginfo-preserve -S -o - < %s 2>&1 | FileCheck %s
+
----------------
This test looks like it could be very costly to maintain. If I understand correctly, it is depending on a bug in InstCombine that isn't further specified, but it's running `opt` with the full `-O2` pipeline on all targets. What guarantees that the bug is actually triggered? Will it trigger on, e.g., an AArch64 host *and* on an x86_64 host? What if someone fixes the bug, or worse, if the pipeline changes, such that the bug isn't triggered any more — how should they update this testcase?
It would be better do do something very targeted. For example we could implement (in a unit test) a extremely simple pass that just deletes debug info intrinsics and run the check on that. This way we we will get a deterministic behavior on all targets and future compiler versions.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82545/new/

https://reviews.llvm.org/D82545