[PATCH] D95373: Replace vector intrinsics with call to vector library

[Roman Lebedev via Phabricator via llvm-commits]

lebedev.ri added a comment.

In D95373#2525396 <https://reviews.llvm.org/D95373#2525396>, @spatel wrote:

> In D95373#2523413 <https://reviews.llvm.org/D95373#2523413>, @craig.topper wrote:
>
>> Does GlobalISel also use CGP? Do we want to emit vector libcalls for vector IR intrinsics at O0? If I recall, CGP is disabled at O0.
>
> GlobalISel should not use CGP in the long-run since CGP was purely a hack to overcome SDAG's single-block limitation. I'm not sure what the status is for GlobalISel targets currently though.
>
> In D95373#2524237 <https://reviews.llvm.org/D95373#2524237>, @venkataramanan.kumar.llvm wrote:
>
>> Can this be scheduled as a pre code generation pass ?
>
> I haven't actually looked at the patch details, but if there's agreement that it's ok to leave it as an IR transform, then it should be a small adjustment to make this an IR codegen pass. It would be similar to the existing `ExpandReductions` pass.

That is what i was suggesting to do FWIW.
Perhaps, this makes sense as middle-end optimization, but then we should have intrinsics instead of all these libcalls,
and somehow everything would need to be updated to be okay with that, but that will require a *much* larger changes.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95373/new/

https://reviews.llvm.org/D95373