[PATCH] D95463: Avoid redundant or out-of-order debug value sinking in InstCombine

[Jeremy Morse via Phabricator via llvm-commits]

jmorse added inline comments.


================
Comment at: llvm/test/Transforms/InstCombine/debuginfo-sink.ll:74-75
+sink1:
+; CHECK-LABEL: sink1:
+; CHECK:       call void @llvm.dbg.value(metadata i32* %gep,
+; CHECK-SAME:  metadata !{{[0-9]+}}, metadata !DIExpression(DW_OP_plus_uconst, 5))
----------------
Doesn't this need a `CHECK-NOT dbg.value` in there, to verify that only one dbg.value is sunk?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95463/new/

https://reviews.llvm.org/D95463