[PATCH] D95469: [flang][openacc] Allow multiple wait clauses

[Sourabh Singh Tomar via Phabricator via llvm-commits]

SouraVX accepted this revision.
SouraVX added a comment.
This revision is now accepted and ready to land.

LGTM!



================
Comment at: flang/test/Semantics/OpenACC/acc-data.f90:62
 
   !$acc enter data create(aa) wait(wait1)
 
----------------
clementval wrote:
> kiranchandramohan wrote:
> > SouraVX wrote:
> > > Looking at it, I assume `wait1` is an event of some kind ? That `data create` directive is waiting for finishing ?
> > > Then again where is `wait1` defined ?
> > > Could you point me to the spec WRT this clause.
> > Spec: https://www.openacc.org/sites/default/files/inline-images/Specification/OpenACC-3.1-final.pdf
> > 
> > In Section 2.16.2 it says "If there is an argument to the wait clause, it must be a wait argument (See 2.16.3)."
> > 
> > Section 2.16.3/Page 80
> > ```
> > The wait argument, if it appears, must be a wait-argument where wait-argument is:
> > [ devnum : int-expr : ] [ queues : ] int-expr-list
> > ```
> > 
> The @kiranchandramohan for mentioning the spec. Basically the most basic wait argument is just a int-expr. You can see it as a stream number in CUDA. 
Thanks for the stream number analogy :)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95469/new/

https://reviews.llvm.org/D95469