[PATCH] D95481: [flang] Search for #include "file" in right directory (take 2)
Andrzej Warzynski via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Jan 27 07:25:31 PST 2021
awarzynski accepted this revision.
awarzynski added a comment.
This revision is now accepted and ready to land.
Thank you for re-submitting this so quickly @klausler !
These changes look good to me. I have one question about module files - is it safe to assume that modules with version information `v1` are always going to be supported? I'm concerned that when we bump the version then we will also have to update the uploaded module files.
================
Comment at: flang/test/Flang-Driver/include-module.f90:21
+! SINGLEINCLUDE:Error reading module file for module 'basictestmoduletwo'
! SINGLEINCLUDE-NOT:Error reading module file for module 'basictestmoduletwo'
+! SINGLEINCLUDE-NOT:error: Derived type 't1' not found
----------------
[nit] This and the line above are mutually exclusive, right? So this line could safely be deleted. Or replaced with:
```
! SINGLEINCLUDE:Source file 'basictestmoduletwo.mod' was not found
```
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D95481/new/
https://reviews.llvm.org/D95481
More information about the llvm-commits
mailing list