[PATCH] D94668: [debug-info] [NFC] add isa support for MCStreamer

Wed Jan 27 05:44:32 PST 2021

shchenz added a comment.

In D94668#2500791 <https://reviews.llvm.org/D94668#2500791>, @ikudrin wrote:

> Is it possible to encapsulate the target-specific logic into some derived classes from `MCStreamer` so that `MCStreamer` itself and DWARF emitter classes work through a common interface and have no target-specific adjustments?

Thanks for your comments @ikudrin I know what you mean. But for the use cases in D95518 <https://reviews.llvm.org/D95518>, we need to differentiate `MCAsmStreamer` and `MCObjectStreamer` in many classes that contain an `MCStreamer` pointer. I am not sure if a common interface in `MCStreamer` class can be easily and logically found. For example the uses in file lib/CodeGen/AsmPrinter/DwarfCompileUnit.cpp in D95518 <https://reviews.llvm.org/D95518>. Could you please help to look at the consumer patch D95518 <https://reviews.llvm.org/D95518> and tell me what you think? Thanks again.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94668/new/

https://reviews.llvm.org/D94668