[PATCH] D94072: [MC][ELF] Fix accepting abbreviated form with sh_flags and sh_entsize

[James Henderson via Phabricator via llvm-commits]

jhenderson added a comment.

Thanks - that explanation sounds reasonable to me. I'm not sure I really understand @MaskRay's concerns here. This seems like a pretty clear-cut bug in the previous fix.



================
Comment at: llvm/test/MC/ELF/section-omitted-attributes.s:14
+
+.section .rodata.cst8,"aM", at progbits,8
+
----------------
Add a comment why you have this second case.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94072/new/

https://reviews.llvm.org/D94072