[PATCH] D95513: [llvm-objdump][test] Fix --prefix tests for system-windows

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 27 05:35:31 PST 2021


jhenderson added a comment.

LGTM, with a couple of nits. Please leave it for about 24 hours to give others a chance to comment, should they wish.



================
Comment at: llvm/test/tools/llvm-objdump/X86/source-interleave-prefix-non-windows.test:4
 
-;; Test removal of trailing separators (only '/').
+;; Test removal of trailing separators (only '/' in non system-windows).
 ;; The prefix 'myprefix/\' is not changed.
----------------
`system-windows` is just a lit tag, and isn't the name of anything.


================
Comment at: llvm/test/tools/llvm-objdump/X86/source-interleave-prefix-windows.test:4
+
+;; Test removal of trailing separators (both '/' and '\' in system-windows).
+;; The prefix 'myprefix/\' is changed to 'myprefix'.
----------------



CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95513/new/

https://reviews.llvm.org/D95513



More information about the llvm-commits mailing list