[PATCH] D95513: [llvm-objdump][test] Fix --prefix tests for system-windows

Wed Jan 27 02:19:41 PST 2021

jhenderson added inline comments.

================
Comment at: llvm/test/tools/llvm-objdump/X86/source-interleave-prefix-windows.test:1
+;; Test --prefix option platform specific behavior.
+; REQUIRES: system-windows
----------------
Could you expand this comment to explain what the platform-specific behaviour is, please? (I'm guessing it's related to the trailing separator comment below).

================
Comment at: llvm/test/tools/llvm-objdump/X86/source-interleave-prefix-windows.test:11
+; CHECK: warning: '[[FILE]]': failed to find source [[PREFIX]]/Inputs\source-interleave-x86_64.c
\ No newline at end of file

----------------
Nit: no new line at EOF.

================
Comment at: llvm/test/tools/llvm-objdump/X86/source-interleave-prefix.test:45
+; RUN:   FileCheck %s --check-prefix=CHECK-BROKEN-PREFIX -DFILE=%t-missing-prefix.o -DPREFIX=myprefix
\ No newline at end of file

----------------
Nit: no new line at EOF.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95513/new/

https://reviews.llvm.org/D95513