[PATCH] D95461: [llvm-nm] Display defined weak STT_GNU_IFUNC symbols as 'i'

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 27 01:56:42 PST 2021


jhenderson added a comment.

Frankly, the llvm-nm code in this area feels like a bit of a mess, but this is at least an improvement. Just one test suggestion. Otherwise, this looks good.



================
Comment at: llvm/test/tools/llvm-nm/ifunc.test:34-36
+  - Name:    ifunc_undef
+    Type:    STT_GNU_IFUNC
+    Binding: STB_GLOBAL
----------------
Maybe worth a weak undefined case too.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95461/new/

https://reviews.llvm.org/D95461



More information about the llvm-commits mailing list