[PATCH] D95341: [yaml2obj] - Allow empty SectionHeaderTable definitions.

Wed Jan 27 01:49:47 PST 2021

jhenderson accepted this revision.
jhenderson added a comment.
This revision is now accepted and ready to land.

LGTM.

In D95341#2524529 <https://reviews.llvm.org/D95341#2524529>, @grimar wrote:

> Hi guys.
> I am sorry for pinging this too early, but I am planning a ~6 weeks vacation starting from 1st of february
> and I wonder if there is something I can do for this to land it or if there are any concerns about this change?

No problem. Somehow this slipped off my review pile, so I hadn't seen it. Let me know if there are any other reviews I haven't done by the end of the day.

================
Comment at: llvm/test/tools/yaml2obj/ELF/section-headers.yaml:155
+## Check that we allow using an empty SectionHeaderTable definition.
+## It can be used to emit a default section header content at an arbitrary position.

----------------
I think this sounds better English to me, though I can't place specifically what was wrong before!

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95341/new/

https://reviews.llvm.org/D95341